Use the Pkg.Registry API #39
Conversation
danielmatz
force-pushed
the
use-pkg-registry-api
branch
from
fb6ddf6 to
f8752c0
Compare
|
We now use I tested this locally on Julia 1.6 and 1.7, but I'd appreciate an extra set of eyes to make sure I didn't mess anything up. |
|
This package had its workflows disabled, things look good to me though. Not sure how to re-kick the CI to run, maybe just this comment will be enough? If not could you amend a commit message, force push back and that should start the job? |
As of Julia 1.7, Pkg.Registry provides some of the same capability implemented in this package. When `VERSION` is at least v1.7, we use `Pkg.Registry.reachable_registries`, `Pkg.Registry.RegistryInstance`, and `Pkg.Registry.PkgEntry` instead of the custom versions implemented in this package. For lower version numbers, we use the custom versions implemented in this package. The largest change when using the new capabilities in Pkg.Registry is that this package's version of `RegistryInstance` stored a dictionary mapping package names to `PkgEntry`s, but Pkg.Registry's version has a dictionary mapping `UUID`s to `PkgEntry`s. A benefit of using the `Pkg.Registry` API is that it already supports both uncompressed registries as well as registries stored in compressed tarballs. Thus, this fixes JuliaEcosystem#37.
danielmatz
force-pushed
the
use-pkg-registry-api
branch
from
f8752c0 to
59473f4
Compare
|
I force pushed, but now it seems to be waiting for your approval. |
|
Yet another option is to use https://github.com/GunnarFarneback/RegistryInstances.jl (and this package was actually already suggested as a possible beneficiary) |
|
I finally had some time to look at this again. I've created yet another pull request that takes the approach of using RegistryInstances. See #42. I'll close this in favor of that new PR. |
As of Julia 1.7, Pkg.Registry provides some of the capability that had
been implemented in this package. This commit makes this package's
reachable_registriesa simple wrapper aroundPkg.Registry.reachable_registriesand removes theRegistryInstanceand
PkgEntrytypes in favor of the types of the same name inPkg.Registry.
The largest change is that this package's version of
RegistryInstancestored a dictionary mapping package names toPkgEntrys, but Pkg.Registry's version has a dictionary mappingUUIDs toPkgEntrys.A benefit of using the
Pkg.RegistryAPI is that it already supportsboth uncompressed registries as well as registries stored in
compressed tarballs. Thus, this fixes #37.